Skip to content

feat(structured-properties): implement infinite scroll with backend search for structured properties table #14991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

feat(structured-properties): implement infinite scroll with backend search for structured properties table #14991

wants to merge 11 commits into from

Conversation

@purnimagarg1
Copy link
Collaborator

@purnimagarg1 purnimagarg1 commented Oct 13, 2025 •
edited
Loading

Linear tickets:
https://linear.app/acryl-data/issue/CH-811/implement-infinite-scroll-in-structured-properties-table
https://linear.app/acryl-data/issue/CH-813/update-the-search-functionality-in-structured-properties-to-do-a

Description:

This PR adds support for infinite scroll in tables with TableWithInfiniteScroll inside Table folder in components.
It then implements TableWithInfiniteScroll in structured properties.

It also changes the search implementation for structured properties to use backend search. It implements autocomplete on structured property entities and uses that for search. So, autoCompleteResults query (max 200 items) is used for search and searchResultsForMultipleQuery is used for fetching properties (without search) with infinite scroll.

It also handles the way immediate feedback is shown to the user. Instead of using cache, we now handle it inside useInfiniteScroll hook (keeping it generic) and update the states to show immediate feedback after add, remove and update of structured properties.

Video:

Screen.Recording.2025-10-14.at.5.38.45.PM.mov

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 13, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 13, 2025
@codecov
Copy link

codecov bot commented Oct 13, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 93.82716% with 5 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...pes/structuredproperty/StructuredPropertyType.java 0.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Oct 13, 2025 •
edited
Loading

🔴 Meticulous spotted visual differences in 55 of 1090 screens tested: view and approve differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit c3bd7a1. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Oct 13, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 783 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.58MB 783 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 783 bytes 18.95MB 0.0%

Files in assets/index-*.js:

  • ./src/app/searchV2/utils/constants.ts → Total Size: 5.28kB

  • ./src/app/govern/structuredProperties/StructuredProperties.tsx → Total Size: 5.14kB

  • ./src/app/govern/structuredProperties/ViewStructuredPropsDrawer.tsx → Total Size: 4.52kB

  • ./src/app/govern/structuredProperties/StructuredPropsDrawer.tsx → Total Size: 12.03kB

  • ./src/alchemy-components/components/Table/Table.tsx → Total Size: 7.75kB

  • ./src/alchemy-components/components/Table/types.ts → Total Size: 236 bytes

  • ./src/app/govern/structuredProperties/StructuredPropsForm.tsx → Total Size: 2.99kB

  • ./src/alchemy-components/components/Table/TableWithInfiniteScroll.tsx → Total Size: 1.9kB

  • ./src/app/govern/structuredProperties/StructuredPropsTable.tsx → Total Size: 9.75kB

  • ./src/alchemy-components/components/InfiniteScrollList/useInfiniteScroll.ts → Total Size: 2.85kB

  • ./src/app/govern/structuredProperties/StructuredPropsFormSection.tsx → Total Size: 4.33kB

  • ./src/alchemy-components/components/InfiniteScrollList/InfiniteScrollList.tsx → Total Size: 715 bytes

  • ./src/app/govern/structuredProperties/useStructuredProp.ts → Total Size: 3.68kB

  • ./src/alchemy-components/components/InfiniteScrollList/components.ts → Total Size: 78 bytes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@purnimagarg1